ref(aws-serverless): Remove dead vendored aws-sdk OTel instrumentation - #22825
Merged
Conversation
The vendored OpenTelemetry `AwsInstrumentation` and its service extensions are dead code: aws-sdk spans come from the channel-based `awsIntegration()` in `@sentry/server-utils`, and nothing instantiated the vendored class. Remove the whole tree and the now-unused `@opentelemetry/instrumentation` and `@opentelemetry/api` dependencies. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Member
Author
|
batman begin |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 39e8120. Configure here.
nicohrubec
approved these changes
Jul 29, 2026
andreiborza
marked this pull request as ready for review
July 29, 2026 13:12
andreiborza
requested review from
isaacs and
mydea
and removed request for
a team
July 29, 2026 13:12
andreiborza
enabled auto-merge (squash)
July 29, 2026 13:12
Contributor
size-limit report 📦
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Remove the dead vendored OpenTelemetry aws-sdk instrumentation from
@sentry/aws-serverless.src/integration/aws/tree (theAwsInstrumentationInstrumentationBaseand its vendored service extensions).@opentelemetry/instrumentationand@opentelemetry/apidependencies, plus the stale@opentelemetry/apirollup external.Why
aws-sdk spans already come from the channel-based
awsIntegration()in@sentry/server-utils. The vendored class was never instantiated, so this is pure dead-code removal with no behavior change.Closes: #22775